Skip to content

chore: add type to all rules #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 23, 2018
Merged

chore: add type to all rules #673

merged 3 commits into from
Nov 23, 2018

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Nov 18, 2018 •
edited
Loading

Make sure that --fix-type cli parameter works with our plugin

https://eslint.org/docs/developer-guide/working-with-rules#rule-basics

@armano2
chore: add type to all rules
8be490b 
Make sure that --fix-type cli parameter works with our plugin
mysticatea
mysticatea reviewed Nov 19, 2018
View reviewed changes
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!

I have some suggestions for the type. Would you take a look?

@armano2
Copy link
Contributor Author

armano2 commented Nov 19, 2018

v-on-style and v-bind-style determines only how code looks not how its executed

@mysticatea
Copy link
Member

mysticatea commented Nov 19, 2018 •
edited
Loading

Those two appear on vue-eslint-parser's AST as shorthand property, but indeed, those don't change semantics.

Hm, It's OK.

mysticatea
mysticatea approved these changes Nov 19, 2018
View reviewed changes
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@michalsnik michalsnik merged commit b18d351 into vuejs:master Nov 23, 2018
@armano2 armano2 deleted the fix-type branch November 23, 2018 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysticatea mysticatea mysticatea approved these changes

@michalsnik michalsnik michalsnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@armano2 @mysticatea @michalsnik